Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 533543004: WebMediaPlayerImpl should notify ended event

Created:
6 years, 3 months ago by amogh.bihani
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebMediaPlayerImpl should notify ended event HTMLMediaElement determines ended event by comparing two doubles. Sometimes it happens that the current time is not exactly equal to the duration. Because of this the event is not fired. This patch relays the ended event notification from WebMediaPlayerImpl to HTMLMediaElement. This will avoid comparision between two doubles. BUG=409280, 349543

Patch Set 1 #

Patch Set 2 : Sending duration changed when pipeline ends #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
amogh.bihani
PTAL. This will land on top of https://codereview.chromium.org/530993002/
6 years, 3 months ago (2014-09-02 12:19:45 UTC) #2
scherkus (not reviewing)
Thanks -- lets focus on landing https://codereview.chromium.org/530993002/ first
6 years, 3 months ago (2014-09-02 20:30:50 UTC) #3
amogh.bihani
6 years, 3 months ago (2014-09-10 08:44:04 UTC) #5
On 2014/09/02 20:30:50, scherkus wrote:
> Thanks -- lets focus on landing https://codereview.chromium.org/530993002/
first

Changes done as per the comments in https://codereview.chromium.org/530993002/

Powered by Google App Engine
This is Rietveld 408576698