Credential Manager: Refactor password_manager::CredentialManagerClient.

Credential Manager: Refactor password_manager::CredentialManagerClient.

password_manager::CredentialManagerClient was a RenderProcessObserver,
and sent messages via RenderThread. This couldn't possibly have ever
worked; the messages it sent were simply dropped on the floor.

After this patch, it's a RenderViewObserver and its messages
successfully land in the ChromePasswordManagerClient, just as they
ought to.

BUG=400674
Committed: https://crrev.com/4ea2bcacd49f172b9e49a1b2aea112ad04512687
Cr-Commit-Position: refs/heads/master@{#292932}

[Mike West, 2014-09-02 11:56:11]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org, vabr@chromium.org

[Mike West, 2014-09-02 11:56:11]

Thanks for working through this with me, Jochen. Mind taking a look at the
result?

vabr@: Can you check out the password_manager component changes as well?

Thanks!

[jochen (gone - plz use gerrit), 2014-09-02 12:08:15]

lgtm

https://codereview.chromium.org/533493004/diff/20001/components/password_mana...
File components/password_manager/content/renderer/credential_manager_client.h
(right):

https://codereview.chromium.org/533493004/diff/20001/components/password_mana...
components/password_manager/content/renderer/credential_manager_client.h:50:
CredentialManagerClient(content::RenderView* render_view);
explicit

[vabr (Chromium), 2014-09-02 14:16:59]

LGTM, thanks for educating me. :)

[Mike West, 2014-09-02 14:19:43]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-02 14:19:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/533493004/40001

[commit-bot: I haz the power, 2014-09-02 15:38:13]

Committed patchset #3 (id:40001) as 9dfbec34ac75d4a936623b0dfed57b8c20e35700

[commit-bot: I haz the power, 2014-09-10 03:18:41]

Patchset 3 (id:??) landed as
https://crrev.com/4ea2bcacd49f172b9e49a1b2aea112ad04512687
Cr-Commit-Position: refs/heads/master@{#292932}