[Telemetry] Add recognition for OS X 10.10 Yosemite

[Telemetry] Add recognition for OS X 10.10 Yosemite

BUG=409919
Committed: https://crrev.com/b0b8648dc4298ee5cd46259bae0da66d04a631f9
Cr-Commit-Position: refs/heads/master@{#293017}

[smut, 2014-09-02 18:20:12]

smut@google.com changed reviewers:
+ tonyg@chromium.org

[smut, 2014-09-02 18:20:13]

Tony,

I've never filed a telemetry CL before, but in case the fix for the bug I filed
is this easy, here it is. I am sending the CL to you because your name was on
the blamelist for the relevant files. Please redirect as necessary.

Thanks.

[tonyg, 2014-09-02 18:30:13]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-09-02 18:30:13]

lgtm

Thanks!

[commit-bot: I haz the power, 2014-09-02 18:31:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/smut@google.com/533443003/1

[commit-bot: I haz the power, 2014-09-02 19:31:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[smut, 2014-09-02 19:54:19]

On 2014/09/02 19:31:00, I haz the power (commit-bot) wrote:
> FYI, CQ is re-trying this CL (attempt #1).
> The failing builders are:
>   linux_chromium_rel_swarming on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_rel_swarming on tryserver.chromium.mac
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
>   win_chromium_rel_swarming on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
>   win_chromium_x64_rel_swarming on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

So the problem is that it thinks 10.10 is a base 10 number, meaning it is 10.1,
and therefore it sorts as the least recent version. There are a few solutions to
this, and I can implement one of them. Are you familiar with where all
platform_backend.OSVersion is used? Will there be much of an impact if I change
it?

[smut, 2014-09-02 19:54:23]

The CQ bit was unchecked by smut@google.com

[smut, 2014-09-02 21:10:33]

Patchset #2 (id:20001) has been deleted

[tonyg, 2014-09-02 21:31:19]

On 2014/09/02 19:54:19, smut wrote:
> On 2014/09/02 19:31:00, I haz the power (commit-bot) wrote:
> > FYI, CQ is re-trying this CL (attempt #1).
> > The failing builders are:
> >   linux_chromium_rel_swarming on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> >   mac_chromium_rel_swarming on tryserver.chromium.mac
> >
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> >   win_chromium_rel_swarming on tryserver.chromium.win
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> >   win_chromium_x64_rel_swarming on tryserver.chromium.win
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> 
> So the problem is that it thinks 10.10 is a base 10 number, meaning it is
10.1,
> and therefore it sorts as the least recent version. There are a few solutions
to
> this, and I can implement one of them. Are you familiar with where all
> platform_backend.OSVersion is used? Will there be much of an impact if I
change
> it?

I think this is the only other place that needs to be updated:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

You could update that and go w/ this major/minor approach. Or avoid changing the
interface in favor of using 1010, 1009, 1008, etc.

[smut, 2014-09-02 21:49:04]

Patchset #2 (id:40001) has been deleted

[smut, 2014-09-02 21:50:56]

On 2014/09/02 21:31:19, tonyg wrote:
> On 2014/09/02 19:54:19, smut wrote:
> > On 2014/09/02 19:31:00, I haz the power (commit-bot) wrote:
> > > FYI, CQ is re-trying this CL (attempt #1).
> > > The failing builders are:
> > >   linux_chromium_rel_swarming on tryserver.chromium.linux
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > >   mac_chromium_rel_swarming on tryserver.chromium.mac
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > >   win_chromium_rel_swarming on tryserver.chromium.win
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> > >   win_chromium_x64_rel_swarming on tryserver.chromium.win
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> > 
> > So the problem is that it thinks 10.10 is a base 10 number, meaning it is
> 10.1,
> > and therefore it sorts as the least recent version. There are a few
solutions
> to
> > this, and I can implement one of them. Are you familiar with where all
> > platform_backend.OSVersion is used? Will there be much of an impact if I
> change
> > it?
> 
> I think this is the only other place that needs to be updated:
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> 
> You could update that and go w/ this major/minor approach. Or avoid changing
the
> interface in favor of using 1010, 1009, 1008, etc.

Ok, I wasn't sure if anything was relying on the sortable version to be 10.10
and not 1010. I've done it that way since it's easier. That said, this approach
will need revising if/when 11.0 comes out, since 110 < 1010.

[smut, 2014-09-02 21:51:12]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2014-09-02 21:51:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/smut@google.com/533443003/60001

[commit-bot: I haz the power, 2014-09-02 23:11:49]

Committed patchset #2 (id:60001) as 97070903e55205cafc6c82336b8bfd27bd424bae

[commit-bot: I haz the power, 2014-09-10 03:21:42]

Patchset 2 (id:??) landed as
https://crrev.com/b0b8648dc4298ee5cd46259bae0da66d04a631f9
Cr-Commit-Position: refs/heads/master@{#293017}