Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 533423003: cc: Added last_assign_oomed bool into tile manager traces. (Closed)

Created:
6 years, 3 months ago by vmpstr
Modified:
6 years, 3 months ago
Reviewers:
nduca, reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Added last_assign_oomed bool into tile manager traces. This patch adds a flag indiciating whether we were OOM the last time we did an assign. R=reveman, nduca BUG=408758, 410398 Committed: https://crrev.com/dcd03ea452e43039934657259674cd2e0848bc61 Cr-Commit-Position: refs/heads/master@{#294602}

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/resources/tile_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
vmpstr
PTAL
6 years, 3 months ago (2014-09-03 22:48:27 UTC) #1
vmpstr
ping
6 years, 3 months ago (2014-09-09 00:17:59 UTC) #2
reveman
don't we get this already from the over_memory_budget counter?
6 years, 3 months ago (2014-09-09 01:55:36 UTC) #3
nduca
we need it in the frame viewer dump so the viewer itself can use it. ...
6 years, 3 months ago (2014-09-09 17:48:02 UTC) #4
nduca
lgtm if david is okay with it, lets call it did_oom_on_last_assign
6 years, 3 months ago (2014-09-09 17:48:36 UTC) #5
reveman
On 2014/09/09 17:48:02, nduca wrote: > we need it in the frame viewer dump so ...
6 years, 3 months ago (2014-09-09 18:36:10 UTC) #6
vmpstr
On 2014/09/09 17:48:36, nduca wrote: > lgtm if david is okay with it, lets call ...
6 years, 3 months ago (2014-09-09 19:27:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/533423003/20001
6 years, 3 months ago (2014-09-09 19:34:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/11788)
6 years, 3 months ago (2014-09-09 21:21:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/533423003/20001
6 years, 3 months ago (2014-09-12 15:50:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f3368e958bb321ca77714f5c3782c0841dd83a7d
6 years, 3 months ago (2014-09-12 16:37:06 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:39:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcd03ea452e43039934657259674cd2e0848bc61
Cr-Commit-Position: refs/heads/master@{#294602}

Powered by Google App Engine
This is Rietveld 408576698