media/media.gyp - Issue 533423002: Include Mac media glue code in iOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/media.gyp

Issue 533423002: Include Mac media glue code in iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base-glue

Patch Set: Avoid using regular expression patterns to match multiple files in inclusion rules. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/media.gyp

diff --git a/media/media.gyp b/media/media.gyp

index 197c153d7fd084d7fb4c399259b6f23ffffea600..5fb0366a4c35a18a9622b3f3fb3c0d1e3c8033eb 100644

--- a/media/media.gyp

+++ b/media/media.gyp

@@ -988,7 +988,19 @@

'base/keyboard_event_counter.h',

}],

- ],

+ ], # conditions

+ 'target_conditions': [

+ ['OS == "ios" and _toolset != "host"', {

+ 'sources/': [

DaleCurtis 2014/09/05 17:28:48 Why still use regex instead just sources: [ <a>, <

+ # Pull in specific Mac files for iOS (which have been filtered out

+ # by file name rules).

+ ['include', '^base/mac/avfoundation_glue\\.h$'],

+ ['include', '^base/mac/avfoundation_glue\\.mm$'],

+ ['include', '^base/mac/coremedia_glue\\.h$'],

+ ['include', '^base/mac/coremedia_glue\\.mm$'],

+ ],

+ }],

+ ], # target_conditions

{

# GN version: //media/mojo/interfaces

« no previous file with comments | « media/BUILD.gn ('k') | no next file » | no next file with comments »