Include Mac media glue code in iOS builds.

Include Mac media glue code in iOS builds.

BUG=410527
R=rsesek, DaleCurtis

Committed: https://crrev.com/dba29b0688ad137a4e482ef4347469df85883a8b
Cr-Commit-Position: refs/heads/master@{#293782}

[Robert Sesek, 2014-09-04 14:28:35]

LGTM

[DaleCurtis, 2014-09-04 23:05:03]

lgtm % nits

https://codereview.chromium.org/533423002/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/533423002/diff/1/media/media.gyp#newcode997
media/media.gyp:997: ['include', '^base/mac/avfoundation_glue\\.(h|mm)$'],
Please list these explicitly. These type of patterns are hard to follow.

[jfroy, 2014-09-05 16:02:51]

Patchset #2 (id:20001) has been deleted

[jfroy, 2014-09-05 16:06:36]

Waiting for approval before adding to CQ.

https://codereview.chromium.org/533423002/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/533423002/diff/1/media/media.gyp#newcode997
media/media.gyp:997: ['include', '^base/mac/avfoundation_glue\\.(h|mm)$'],
On 2014/09/04 23:05:03, DaleCurtis wrote:
> Please list these explicitly. These type of patterns are hard to follow.

Done.

[DaleCurtis, 2014-09-05 17:28:48]

https://codereview.chromium.org/533423002/diff/60001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/533423002/diff/60001/media/media.gyp#newcode994
media/media.gyp:994: 'sources/': [
Why still use regex instead just sources: [ <a>, <b>, <c> ] ?

[jfroy, 2014-09-05 17:36:02]

On 2014/09/05 17:28:48, DaleCurtis wrote:
> https://codereview.chromium.org/533423002/diff/60001/media/media.gyp
> File media/media.gyp (right):
> 
>
https://codereview.chromium.org/533423002/diff/60001/media/media.gyp#newcode994
> media/media.gyp:994: 'sources/': [
> Why still use regex instead just sources: [ <a>, <b>, <c> ] ?

As far as I understand gyp, you must use a regular expression in include rules.
https://code.google.com/p/gyp/wiki/InputFormatReference#Pattern_Lists_(/)

[DaleCurtis, 2014-09-05 17:55:55]

Yes, but doesn't just listing them in the sources field include them?

[jfroy, 2014-09-05 18:03:31]

On 2014/09/05 17:55:55, DaleCurtis wrote:
> Yes, but doesn't just listing them in the sources field include them?

No, they get excluded by exclude rules in build/filename_rules.gypi. They need
to be explicitly added back to iOS builds via later-evaluated include rules.

[DaleCurtis, 2014-09-05 18:19:26]

lgtm

Ah, that's unfortunate, your ps#2 was fine then.

[jfroy, 2014-09-05 18:27:28]

On 2014/09/05 18:19:26, DaleCurtis wrote:
> lgtm
> 
> Ah, that's unfortunate, your ps#2 was fine then.

I don't mind being explicit.

[jfroy, 2014-09-05 18:27:32]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-05 18:29:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/60001

[commit-bot: I haz the power, 2014-09-05 19:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:20:35]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[jfroy, 2014-09-05 22:01:03]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-05 22:02:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/80001

[commit-bot: I haz the power, 2014-09-06 04:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 04:05:20]

Exceeded time limit waiting for builds to trigger.

[jfroy, 2014-09-06 22:02:20]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-06 22:03:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/100001

[commit-bot: I haz the power, 2014-09-06 23:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 23:50:21]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[jfroy, 2014-09-07 05:15:01]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-07 05:16:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/120001

[commit-bot: I haz the power, 2014-09-07 07:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-07 07:08:16]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[jfroy, 2014-09-08 17:16:10]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-08 17:19:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/140001

[commit-bot: I haz the power, 2014-09-08 19:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 19:41:57]

Exceeded time limit waiting for builds to trigger.

[jfroy, 2014-09-08 20:08:18]

The CQ bit was checked by jfroy@chromium.org

[commit-bot: I haz the power, 2014-09-08 20:09:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jfroy@chromium.org/533423002/140001

[commit-bot: I haz the power, 2014-09-08 20:44:56]

Committed patchset #7 (id:140001) as 43c2a6e38c642cec883408fef8ddc4580196dff1

[commit-bot: I haz the power, 2014-09-10 03:48:04]

Patchset 7 (id:??) landed as
https://crrev.com/dba29b0688ad137a4e482ef4347469df85883a8b
Cr-Commit-Position: refs/heads/master@{#293782}