Issue 533413002: Group flag comparison output by file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 533413002: Group flag comparison output by file (Closed)

Created:
6 years, 3 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
brettw, awong1

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Group GN/gyp flag comparison output by file Looks like this now: https://gist.github.com/sgraham/1996522958b09077fd92 (vs. very redundant for each file before) R=awong@chromium.org TBR=brettw@chromium.org NOTRY=true Committed: https://crrev.com/0e597a7185766cf864bed1e22b1b1f244268a871 Cr-Commit-Position: refs/heads/master@{#293311}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -21 lines)			Patch
	M	tools/gn/bin/gyp_flag_compare.py	View	1 2 3	4 chunks	+33 lines, -21 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/533413002/60001

6 years, 3 months ago (2014-09-04 17:02:52 UTC) #4

commit-bot: I haz the power

Committed patchset #4 (id:60001) as c49dc3d34eab7407a3920586f10230693bbce68a

6 years, 3 months ago (2014-09-04 17:08:31 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:31:53 UTC) #6

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/0e597a7185766cf864bed1e22b1b1f244268a871
Cr-Commit-Position: refs/heads/master@{#293311}