Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: athena/home/home_card_impl.cc

Issue 533403002: Fix touch selection for Athena home card (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | athena/screen/screen_manager_impl.cc » ('j') | athena/screen/screen_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/home/home_card_impl.cc
diff --git a/athena/home/home_card_impl.cc b/athena/home/home_card_impl.cc
index 0066cf3d3be8e000d6fe2972df30c5e20fa8b190..c267a906569dcfc4ae3ecbfa12df1b2b37cf6b99 100644
--- a/athena/home/home_card_impl.cc
+++ b/athena/home/home_card_impl.cc
@@ -120,11 +120,13 @@ class HomeCardLayoutManager : public aura::LayoutManager {
home_card_ = NULL;
}
virtual void OnWindowRemovedFromLayout(aura::Window* child) OVERRIDE {
- Layout(false);
+ if (!home_card_ || home_card_ == child)
oshima 2014/09/04 00:23:35 why !home_card_ ? Layout is no-op when it's NULL.
Jun Mukai 2014/09/04 00:31:58 This method can simply be empty instead. Anyways,
mohsen 2014/09/04 14:57:22 Yep, this function is no-op in any case. Removed c
+ Layout(false);
}
virtual void OnChildWindowVisibilityChanged(aura::Window* child,
bool visible) OVERRIDE {
- Layout(false);
+ if (home_card_ == child)
+ Layout(false);
}
virtual void SetChildBounds(aura::Window* child,
const gfx::Rect& requested_bounds) OVERRIDE {
« no previous file with comments | « no previous file | athena/screen/screen_manager_impl.cc » ('j') | athena/screen/screen_manager_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698