Fix touch selection for Athena home card

ui/views/touchui/touch_selection_controller_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/touchui/touch_selection_controller_impl.h"
 
 #include "base/time/time.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/env.h"
 #include "ui/aura/window.h"
@@ skipping 419 matching lines @@
     EditingHandleView* handle) {
   dragging_handle_ = handle;
   if (dragging_handle_)
     HideContextMenu();
   else
     StartContextMenuTimer();
 }
 
 void TouchSelectionControllerImpl::SelectionHandleDragged(
     const gfx::Point& drag_pos) {
-  // We do not want to show the context menu while dragging.
-  HideContextMenu();

[oshima, 2014/09/04 00:23:35]

are these change intentional?

[mohsen, 2014/09/04 14:57:22]

Yes. These are not needed. For this case, context menu is already hidden in
SetDraggingHandle() which is called before this one. For the one in
OnWidgetBoundsChanged(), HideContextMenu() is called in next line's call to
SelectionChanged() if needed.

-
   DCHECK(dragging_handle_);
   gfx::Point drag_pos_in_client = drag_pos;
   ConvertPointToClientView(dragging_handle_, &drag_pos_in_client);
 
   if (dragging_handle_ == cursor_handle_.get()) {
     client_view_->MoveCaretTo(drag_pos_in_client);
     return;
   }
 
   // Find the stationary selection handle.
@@ skipping 61 matching lines @@
 
 void TouchSelectionControllerImpl::OnWidgetClosing(Widget* widget) {
   DCHECK_EQ(client_widget_, widget);
   client_widget_ = NULL;
 }
 
 void TouchSelectionControllerImpl::OnWidgetBoundsChanged(
     Widget* widget,
     const gfx::Rect& new_bounds) {
   DCHECK_EQ(client_widget_, widget);
-  HideContextMenu();
   SelectionChanged();
 }
 
 void TouchSelectionControllerImpl::OnKeyEvent(ui::KeyEvent* event) {
   client_view_->DestroyTouchSelection();
 }
 
 void TouchSelectionControllerImpl::OnMouseEvent(ui::MouseEvent* event) {
   aura::client::CursorClient* cursor_client = aura::client::GetCursorClient(
       client_view_->GetNativeView()->GetRootWindow());
@@ skipping 86 matching lines @@
 
 bool TouchSelectionControllerImpl::IsSelectionHandle2Visible() {
   return selection_handle_2_->IsWidgetVisible();
 }
 
 bool TouchSelectionControllerImpl::IsCursorHandleVisible() {
   return cursor_handle_->IsWidgetVisible();
 }
 
 }  // namespace views