Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4503)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 533363002: [Android] Add uncategorized bookmark querying JNI bridge function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stars-top-level-brdige
Patch Set: java doc, removed vector Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index b5d51e0098a91c95528c0e258eb53ef4564c6385..6fa52f5ab38b943caae70fa5685a0a29b582578b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -204,6 +204,16 @@ public class BookmarksBridge {
}
/**
+ * @return The uncategorized bookmark IDs. They are sub-bookmarks of mobile and other folders.
Ted C 2014/09/03 20:56:44 I would probably say "direct descendant" instead o
Kibeom Kim (inactive) 2014/09/03 21:00:19 Done.
+ */
+ public List<BookmarkId> getUncategorizedBookmarkIDs() {
+ assert mIsNativeBookmarkModelLoaded;
+ List<BookmarkId> result = new ArrayList<BookmarkId>();
+ nativeGetUncategorizedBookmarkIDs(mNativeBookmarksBridge, result);
+ return result;
+ }
+
+ /**
* Reads sub-folder IDs, sub-bookmark IDs, or both of the given folder.
*
* @param getFolders Whether sub-folders should be returned.
@@ -442,6 +452,8 @@ public class BookmarksBridge {
List<BookmarkId> bookmarksList);
private native void nativeGetTopLevelFolderIDs(long nativeBookmarksBridge, boolean getSpecial,
boolean getNormal, List<BookmarkId> bookmarksList);
+ private native void nativeGetUncategorizedBookmarkIDs(long nativeBookmarksBridge,
+ List<BookmarkId> bookmarksList);
private native void nativeGetChildIDs(long nativeBookmarksBridge, long id, int type,
boolean getFolders, boolean getBookmarks, List<BookmarkId> bookmarksList);
private native void nativeGetAllBookmarkIDsOrderedByCreationDate(long nativeBookmarksBridge,

Powered by Google App Engine
This is Rietveld 408576698