Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 533363002: [Android] Add uncategorized bookmark querying JNI bridge function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stars-top-level-brdige
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
index 71f1c2795801484c3de8722062d2f81855786407..eb6c0728c55b2b191cfb2cb4706420d5311fab39 100644
--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
@@ -245,6 +245,37 @@ void BookmarksBridge::GetTopLevelFolderIDs(JNIEnv* env,
}
}
+void BookmarksBridge::GetUncategorizedBookmarkIDs(JNIEnv* env,
+ jobject obj,
+ jobject j_result_obj) {
+ std::vector<const BookmarkNode*> uncategorized_bookmarks;
+
+ const BookmarkNode* mobile_node = bookmark_model_->mobile_node();
+ for (int i = 0; i < mobile_node->child_count(); ++i) {
+ const BookmarkNode* node = mobile_node->GetChild(i);
+ if (!node->is_folder()) {
+ uncategorized_bookmarks.push_back(node);
+ }
+ }
+
+ const BookmarkNode* other_node = bookmark_model_->other_node();
+ for (int i = 0; i < other_node->child_count(); ++i) {
+ const BookmarkNode* node = other_node->GetChild(i);
+ if (!node->is_folder()) {
+ uncategorized_bookmarks.push_back(node);
+ }
+ }
+
+ for (std::vector<const BookmarkNode*>::const_iterator it =
+ uncategorized_bookmarks.begin(); it != uncategorized_bookmarks.end();
+ ++it) {
+ Java_BookmarksBridge_addToBookmarkIdList(env,
Ted C 2014/09/03 20:49:06 why not add them in the above loops instead of cre
Kibeom Kim (inactive) 2014/09/03 20:54:24 Done.
+ j_result_obj,
+ (*it)->id(),
+ GetBookmarkType(*it));
+ }
+}
+
void BookmarksBridge::GetChildIDs(JNIEnv* env,
jobject obj,
jlong id,

Powered by Google App Engine
This is Rietveld 408576698