Remove RootView::DispatchGestureEvent()

Remove RootView::DispatchGestureEvent()

Remove RootView::DispatchGestureEvent() and instead
call up to the unified event processing logic in
EventProcessor::OnEventFromSource(). This CL
also introduces the virtual method
EventProcessor::OnEventProcessingFinished(),
which is called when the processing of an
event is finished.

BUG=404234
TEST=EventProcessorTest.OnEventProcessingFinished

Committed: https://crrev.com/a46326caf0eb6a4cb51e26dd9cd811984b392aa8
Cr-Commit-Position: refs/heads/master@{#294249}

[tdanderson, 2014-09-09 17:03:57]

tdanderson@chromium.org changed reviewers:
+ sadrul@chromium.org

[tdanderson, 2014-09-09 17:03:58]

Sadrul, please take a look!

[tdanderson, 2014-09-09 17:05:05]

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
File ui/views/widget/root_view.cc (right):

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
ui/views/widget/root_view.cc:313: allow_gesture_event_retargeting_) {
I think it would make more sense if I were to change the name of this member
back to |gesture_handler_set_before_processing_| or something similar. What do
you think?

[sadrul, 2014-09-10 18:15:05]

LGTM

https://codereview.chromium.org/533323004/diff/100001/ui/events/event_process...
File ui/events/event_processor.cc (right):

https://codereview.chromium.org/533323004/diff/100001/ui/events/event_process...
ui/events/event_processor.cc:44: if (details.target_destroyed ||
event->handled())
Can you add a test that OnEventProcessFinished() is called when target is
destroyed / event is handled?

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
File ui/views/widget/root_view.cc (right):

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
ui/views/widget/root_view.cc:313: allow_gesture_event_retargeting_) {
On 2014/09/09 17:05:04, tdanderson wrote:
> I think it would make more sense if I were to change the name of this member
> back to |gesture_handler_set_before_processing_| or something similar. What do
> you think?

Yeah, I think that would be clearer here.

[tdanderson, 2014-09-10 20:32:01]

https://codereview.chromium.org/533323004/diff/100001/ui/events/event_process...
File ui/events/event_processor.cc (right):

https://codereview.chromium.org/533323004/diff/100001/ui/events/event_process...
ui/events/event_processor.cc:44: if (details.target_destroyed ||
event->handled())
On 2014/09/10 18:15:05, sadrul wrote:
> Can you add a test that OnEventProcessFinished() is called when target is
> destroyed / event is handled?

Added the latter.

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
File ui/views/widget/root_view.cc (right):

https://codereview.chromium.org/533323004/diff/100001/ui/views/widget/root_vi...
ui/views/widget/root_view.cc:313: allow_gesture_event_retargeting_) {
On 2014/09/10 18:15:05, sadrul wrote:
> On 2014/09/09 17:05:04, tdanderson wrote:
> > I think it would make more sense if I were to change the name of this member
> > back to |gesture_handler_set_before_processing_| or something similar. What
do
> > you think?
> 
> Yeah, I think that would be clearer here.

Done.

[tdanderson, 2014-09-10 20:32:06]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2014-09-10 20:56:13]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-09-10 20:56:16]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:02:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/533323004/120001

[commit-bot: I haz the power, 2014-09-10 22:50:50]

Committed patchset #7 (id:120001) as 3b184d93bab4dc976937938f36f6e39d69035761

[commit-bot: I haz the power, 2014-09-10 22:59:34]

Patchset 7 (id:??) landed as
https://crrev.com/a46326caf0eb6a4cb51e26dd9cd811984b392aa8
Cr-Commit-Position: refs/heads/master@{#294249}