Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 533323003: Fix glob match and parse tests for Windows and URL styles. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix glob match and parse tests for Windows and URL styles. R=rnystrom@google.com BUG=20788, 20789 Committed: https://code.google.com/p/dart/source/detail?r=39922

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M pkg/glob/test/match_test.dart View 1 4 chunks +15 lines, -5 lines 0 comments Download
M pkg/glob/test/parse_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/pkg.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 3 months ago (2014-09-03 20:13:23 UTC) #1
Bob Nystrom
https://codereview.chromium.org/533323003/diff/1/pkg/glob/test/parse_test.dart File pkg/glob/test/parse_test.dart (right): https://codereview.chromium.org/533323003/diff/1/pkg/glob/test/parse_test.dart#newcode14 pkg/glob/test/parse_test.dart:14: } Can you add an expectation for what this ...
6 years, 3 months ago (2014-09-03 21:24:26 UTC) #2
nweiz
Code review changes
6 years, 3 months ago (2014-09-05 18:26:38 UTC) #3
nweiz
https://codereview.chromium.org/533323003/diff/1/pkg/glob/test/parse_test.dart File pkg/glob/test/parse_test.dart (right): https://codereview.chromium.org/533323003/diff/1/pkg/glob/test/parse_test.dart#newcode14 pkg/glob/test/parse_test.dart:14: } On 2014/09/03 21:24:26, Bob Nystrom wrote: > Can ...
6 years, 3 months ago (2014-09-05 18:26:41 UTC) #4
Bob Nystrom
lgtm
6 years, 3 months ago (2014-09-05 18:59:54 UTC) #5
nweiz
6 years, 3 months ago (2014-09-05 19:04:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698