Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 533213002: Added timezone info for the start date for the fake commits. (Closed)

Created:
6 years, 3 months ago by Sergiy Byelozyorov
Modified:
6 years, 3 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support@master
Visibility:
Public.

Description

Added timezone info for the start date for the fake commits. Mock commits are generated starting from 1970-01-01 00:00 in the local timezone, which in GMT represent to time before the epoch. When datetime objects are converted to Unix timestamp (seconds since epoch), they generate very large numbers that do not fit into an int and are converted to long instead. That broke a test, which validated that the timestamp is not an int. Furthermore, Git hashes for the commit differed because actual timestamps were different in each timezone. R=agable@chromium.org, iannucci@chromium.org Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/01a4a301660003ca7b9a16d3841ecd4c090ea526

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M testing_support/__init__.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M testing_support/git/repo.py View 1 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
Sergiy Byelozyorov
6 years, 3 months ago (2014-09-03 15:11:49 UTC) #1
agable
On 2014/09/03 15:11:49, Sergiy Byelozyorov wrote: LGTM.
6 years, 3 months ago (2014-09-03 15:18:04 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 3 months ago (2014-09-03 15:22:30 UTC) #5
iannucci
Other than that, lgtm https://codereview.chromium.org/533213002/diff/40001/testing_support/git/repo.py File testing_support/git/repo.py (right): https://codereview.chromium.org/533213002/diff/40001/testing_support/git/repo.py#newcode9 testing_support/git/repo.py:9: import pytz there's not pytz ...
6 years, 3 months ago (2014-09-03 15:28:33 UTC) #7
Sergiy Byelozyorov
6 years, 3 months ago (2014-09-03 15:37:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 01a4a30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698