Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/resources/options/automatic_settings_reset_banner.js

Issue 533183002: Revert "Eliminate all code related to the AutomaticProfileResetter." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from dbeam@. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/automatic_settings_reset_banner.js
diff --git a/chrome/browser/resources/options/automatic_settings_reset_banner.js b/chrome/browser/resources/options/automatic_settings_reset_banner.js
index 2a1573eb3f3b14f8b038effde6896c2768dd7047..43b868c23e792a4caaee5372101f5354f0bc5035 100644
--- a/chrome/browser/resources/options/automatic_settings_reset_banner.js
+++ b/chrome/browser/resources/options/automatic_settings_reset_banner.js
@@ -24,12 +24,12 @@ cr.define('options', function() {
* Initializes the banner's event handlers.
*/
initialize: function() {
- this.showMetricName_ = 'AutomaticSettingsReset_WebUIBanner_BannerShown';
+ this.showMetricName = 'AutomaticSettingsReset_WebUIBanner_BannerShown';
- this.dismissNativeCallbackName_ =
+ this.dismissNativeCallbackName =
'onDismissedAutomaticSettingsResetBanner';
- this.setVisibilibyDomElement_ = $('automatic-settings-reset-banner');
+ this.setVisibilityDomElement = $('automatic-settings-reset-banner');
$('automatic-settings-reset-banner-close').onclick = function(event) {
chrome.send('metricsHandler:recordAction',
@@ -49,14 +49,14 @@ cr.define('options', function() {
},
};
- // Forward public APIs to private implementations.
+ // Forward public APIs to protected implementations.
[
'show',
'dismiss',
].forEach(function(name) {
AutomaticSettingsResetBanner[name] = function() {
var instance = AutomaticSettingsResetBanner.getInstance();
- return instance[name + '_'].apply(instance, arguments);
+ return instance[name].apply(instance, arguments);
};
});

Powered by Google App Engine
This is Rietveld 408576698