chrome/browser/resources/options/settings_banner.js - Issue 533183002: Revert "Eliminate all code related to the AutomaticProfileResetter."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/settings_banner.js

Issue 533183002: Revert "Eliminate all code related to the AutomaticProfileResetter." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed next set of comments from gab@. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/settings_banner.css ('K') | « chrome/browser/resources/options/settings_banner.css ('k') | chrome/browser/ui/profile_reset_bubble.h » ('j') | chrome/browser/ui/webui/options/reset_profile_settings_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/settings_banner.js

diff --git a/chrome/browser/resources/options/settings_banner.js b/chrome/browser/resources/options/settings_banner.js

index dc96c08b864a10de2ad538e5331c4d8e3f4b4dde..1b253187e8c161882f9bafe5d624664a54919ad4 100644

--- a/chrome/browser/resources/options/settings_banner.js

+++ b/chrome/browser/resources/options/settings_banner.js

@@ -2,9 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// TODO(engedy): AutomaticSettingsResetBanner is the sole class to derive from

-// SettingsBannerBase. Refactor this into automatic_settings_reset_banner.js.

Dan Beam 2014/09/05 19:21:45 why did you remove? is this done?

engedy 2014/09/10 13:46:26 This would have been necessitated by the very remo

cr.define('options', function() {

/**