Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 533183002: Revert "Eliminate all code related to the AutomaticProfileResetter." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed next set of comments from gab@. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 4543696275af8911abd08c58c616e083e044a2f9..61ae5246f73bfc379687ffd238aea20edcf647e3 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -135,6 +135,7 @@
#include "chrome/browser/android/new_tab_page_prefs.h"
#else
#include "chrome/browser/notifications/sync_notifier/chrome_notifier_service.h"
+#include "chrome/browser/profile_resetter/automatic_profile_resetter_factory.h"
#include "chrome/browser/ui/autofill/generated_credit_card_bubble_controller.h"
#endif
@@ -221,11 +222,12 @@ const char kBackupPref[] = "backup";
// be cleared from user data.
const char kSyncPromoErrorMessage[] = "sync_promo.error_message";
-// The AutomaticProfileResetter service, which has since been unimplemented,
-// used this preference to save that the profile reset prompt had already been
-// shown. We keep the name here for now so that we can clear out legacy values.
+// The AutomaticProfileResetter service used this preference to save that the
+// profile reset prompt had already been shown, however, the preference has been
+// renamed in Local State. We keep the name here for now so that we can clear
+// out legacy values.
// TODO(engedy): Remove this and usages in M42 or later. See crbug.com/398813.
-const char kProfileResetPromptMemento[] = "profile.reset_prompt_memento";
+const char kLegacyProfileResetPromptMemento[] = "profile.reset_prompt_memento";
#endif
} // namespace
@@ -290,6 +292,7 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
#endif // defined(ENABLE_TASK_MANAGER)
#if !defined(OS_ANDROID)
+ AutomaticProfileResetterFactory::RegisterPrefs(registry);
BackgroundModeManager::RegisterPrefs(registry);
RegisterBrowserPrefs(registry);
#if !defined(OS_CHROMEOS)
@@ -351,7 +354,7 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
// Preferences registered only for migration (clearing or moving to a new key)
// go here.
#if !defined(OS_ANDROID)
- registry->RegisterDictionaryPref(kProfileResetPromptMemento);
+ registry->RegisterDictionaryPref(kLegacyProfileResetPromptMemento);
#endif // !defined(OS_ANDROID)
}
@@ -603,7 +606,7 @@ void MigrateBrowserPrefs(Profile* profile, PrefService* local_state) {
}
#if !defined(OS_ANDROID)
- local_state->ClearPref(kProfileResetPromptMemento);
+ local_state->ClearPref(kLegacyProfileResetPromptMemento);
#endif
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698