Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/resources/options/settings_banner.js

Issue 533183002: Revert "Eliminate all code related to the AutomaticProfileResetter." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed next set of comments from gab@. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(engedy): AutomaticSettingsResetBanner is the sole class to derive from
6 // SettingsBannerBase. Refactor this into automatic_settings_reset_banner.js.
Dan Beam 2014/09/05 19:21:45 why did you remove? is this done?
engedy 2014/09/10 13:46:26 This would have been necessitated by the very remo
7
8 cr.define('options', function() { 5 cr.define('options', function() {
9 6
10 /** 7 /**
11 * Base class for banners that appear at the top of the settings page. 8 * Base class for banners that appear at the top of the settings page.
12 */ 9 */
13 function SettingsBannerBase() {} 10 function SettingsBannerBase() {}
14 11
15 cr.addSingletonGetter(SettingsBannerBase); 12 cr.addSingletonGetter(SettingsBannerBase);
16 13
17 SettingsBannerBase.prototype = { 14 SettingsBannerBase.prototype = {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 this.setVisibilibyDomElement_.hidden = !show; 77 this.setVisibilibyDomElement_.hidden = !show;
81 }, 78 },
82 79
83 }; 80 };
84 81
85 // Export 82 // Export
86 return { 83 return {
87 SettingsBannerBase: SettingsBannerBase 84 SettingsBannerBase: SettingsBannerBase
88 }; 85 };
89 }); 86 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698