Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 533173002: Fix conversions from 32-bit pointers to signed 64-bit integers. (Closed)

Created:
6 years, 3 months ago by whywhat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix conversions from 32-bit pointers to signed 64-bit integers. In case the address is a negative 32-bit integer (greater than 0x80000000), it is converted into 64-bit preserving the sign so all the leading bits are set. This results in an invalid 64-bit address. The conversion must be done via an unsigned 32-bit integer (uintptr_t). BUG=409826 Committed: https://crrev.com/1ddc8eb883d03a3dac175832357e5b2889e15134 Cr-Commit-Position: refs/heads/master@{#293140}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disable debug output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/android/linker/linker_jni.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
whywhat
6 years, 3 months ago (2014-09-03 14:12:31 UTC) #2
Yaron
lgtm https://codereview.chromium.org/533173002/diff/1/base/android/linker/linker_jni.cc File base/android/linker/linker_jni.cc (right): https://codereview.chromium.org/533173002/diff/1/base/android/linker/linker_jni.cc#newcode26 base/android/linker/linker_jni.cc:26: #define DEBUG 1 revert
6 years, 3 months ago (2014-09-03 14:24:56 UTC) #3
whywhat
https://codereview.chromium.org/533173002/diff/1/base/android/linker/linker_jni.cc File base/android/linker/linker_jni.cc (right): https://codereview.chromium.org/533173002/diff/1/base/android/linker/linker_jni.cc#newcode26 base/android/linker/linker_jni.cc:26: #define DEBUG 1 On 2014/09/03 14:24:56, Yaron wrote: > ...
6 years, 3 months ago (2014-09-03 14:40:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/533173002/20001
6 years, 3 months ago (2014-09-03 14:41:31 UTC) #6
simonb (inactive)
lgtm Thanks for fixing.
6 years, 3 months ago (2014-09-03 15:09:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ceb0b2d38c6de666735519dd54a34530742398b8
6 years, 3 months ago (2014-09-03 15:41:51 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ddc8eb883d03a3dac175832357e5b2889e15134
Cr-Commit-Position: refs/heads/master@{#293140}

Powered by Google App Engine
This is Rietveld 408576698