pkg/docgen/lib/docgen.dart - Issue 53313007: Change dart:io Platform.script to return a URI. Change all uses of Platform.script to work with th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/docgen/lib/docgen.dart

Issue 53313007: Change dart:io Platform.script to return a URI. Change all uses of Platform.script to work with th… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix dom.py docs Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart ('k') | pkg/http_server/test/utils.dart » ('j') | utils/compiler/create_snapshot.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/docgen/lib/docgen.dart

diff --git a/pkg/docgen/lib/docgen.dart b/pkg/docgen/lib/docgen.dart

index 7378afe7899d9ec67d73edf848f0bb4bf8b64721..1d147c700b939ff33238a2477ac1a655d24d329c 100644

--- a/pkg/docgen/lib/docgen.dart

+++ b/pkg/docgen/lib/docgen.dart

@@ -249,8 +249,7 @@ Future<MirrorSystem> getMirrorSystem(List<String> args, {String packageRoot,

var libraries = !parseSdk ? _listLibraries(args) : _listSdk();

if (libraries.isEmpty) throw new StateError('No Libraries.');

// Finds the root of SDK library based off the location of docgen.

- var sdkRoot = path.join(path.dirname(path.dirname(path.dirname(path.dirname(

- path.absolute(Platform.script))))), 'sdk');

+ var sdkRoot = Platform.script.resolve('../../../sdk').toFilePath();

logger.info('SDK Root: ${sdkRoot}');

return _analyzeLibraries(libraries, sdkRoot, packageRoot: packageRoot);

}

@@ -479,10 +478,9 @@ void _mdnComment(Indexable item) {

//Check if MDN is loaded.

if (_mdn == null) {

// Reading in MDN related json file.

- var mdnDir = path.join(path.dirname(path.dirname(path.dirname(path.dirname(

- path.absolute(Platform.script))))), 'utils', 'apidoc', 'mdn');

- _mdn = JSON.decode(new File(path.join(mdnDir, 'database.json'))

- .readAsStringSync());

+ var mdnDatabase =

+ Platform.script.resolve('../../../utils/apidoc/mdn/database.json');

+ _mdn = JSON.decode(new File(mdnDatabase.toFilePath()).readAsStringSync());

}

if (item.comment.isNotEmpty) return;

var domAnnotation = item.annotations.firstWhere(