[ServiceWorker] Send the body of Request in fetch() API.

Source/modules/serviceworkers/FetchManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "FetchManager.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 240 matching lines @@
     }
 }
 
 void FetchManager::Loader::performNetworkError()
 {
     failed();
 }
 
 void FetchManager::Loader::performHTTPFetch()
 {
+    ASSERT(m_request->url().protocolIsInHTTPFamily());
     // CORS preflight fetch procedure is implemented inside DocumentThreadableLoader.
 
     // "1. Let |HTTPRequest| be a copy of |request|, except that |HTTPRequest|'s
     //  body is a tee of |request|'s body."
     // We use ResourceRequest class for HTTPRequest.
     // FIXME: Support body.
     ResourceRequest request(m_request->url());
     request.setRequestContext(WebURLRequest::RequestContextFetch);
     request.setDownloadToFile(true);
     request.setHTTPMethod(m_request->method());
     const Vector<OwnPtr<FetchHeaderList::Header> >& list = m_request->headerList()->list();
     for (size_t i = 0; i < list.size(); ++i) {
         request.addHTTPHeaderField(AtomicString(list[i]->first), AtomicString(list[i]->second));
     }
 
+    if (m_request->method() != "GET" && m_request->method() != "HEAD") {

[yhirano, 2014/09/04 08:00:55]

I could not find any statement corresponding to this predicate in the spec. Is
there?

[horo, 2014/09/04 11:55:15]

RFC7231 says...
So I think we can ignore the body in GET and HEAD request.

If we send body in GET/HEAD request, DCHECK fails in
WebURLLoaderImpl::Context::Start()
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/web_...
 

+        RefPtr<BlobDataHandle> blobDataHandle = m_request->blobDataHandle();
+        if (blobDataHandle.get()) {
+            RefPtr<FormData> httpBody(FormData::create());
+            httpBody->appendBlob(blobDataHandle->uuid(), blobDataHandle);
+            request.setHTTPBody(httpBody);
+        }
+    }
+
     // "2. Append `Referer`/empty byte sequence, if |HTTPRequest|'s |referrer|
     // is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8
     // encoded, otherwise, to HTTPRequest's header list.
     // We set the referrer using workerGlobalScope's URL in
     // WorkerThreadableLoader.
 
     // "3. Append `Host`, ..."
     // FIXME: Implement this when the spec is fixed.
 
     // "4.If |HTTPRequest|'s force Origin header flag is set, append `Origin`/
@@ skipping 65 matching lines @@
     loader->start();
     return promise;
 }
 
 void FetchManager::onLoaderFinished(Loader* loader)
 {
     m_loaders.remove(loader);
 }
 
 } // namespace blink