Add test that checks function UpdateServerFieldsFromUpdate is working

Add test that checks function UpdateServerFieldsFromUpdate is working
properly  with invalid server's originator_cache_guid and
originator_client_item_id.
It checks UpdateBookmarkPositioning works fine.

BUG=
R=rlarocque@chromium.org

Committed: https://crrev.com/94652f8ec61803b7a6988c9343089068934954d2
Cr-Commit-Position: refs/heads/master@{#293473}

[rlarocque, 2014-09-03 17:34:21]

rlarocque@chromium.org changed reviewers:
+ zea@chromium.org

[rlarocque, 2014-09-03 17:34:22]

I think this is OK, but I'm not working on Chrome anymore so I wouldn't feel
right approving it.  Forwarding to zea@ for review.

[Nicolas Zea, 2014-09-03 20:58:52]

https://codereview.chromium.org/533113002/diff/1/sync/engine/syncer_util_unit...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/533113002/diff/1/sync/engine/syncer_util_unit...
sync/engine/syncer_util_unittest.cc:160: TEST_F(GetUpdatePositionTest,
UpdateServerFieldsFromUpdateTest) {
Comment what the purpose of this test is, here and below. It seems like these
tests are mainly just to verify we don't crash? Especially in the second test,
where the suffix is actually going to wind up being random.

https://codereview.chromium.org/533113002/diff/1/sync/engine/syncer_util_unit...
sync/engine/syncer_util_unittest.cc:161: // Initialize update with valid data
nit: periods after comments (here and below)

[reat, 2014-09-04 04:32:20]

https://codereview.chromium.org/533113002/diff/1/sync/engine/syncer_util_unit...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/533113002/diff/1/sync/engine/syncer_util_unit...
sync/engine/syncer_util_unittest.cc:160: TEST_F(GetUpdatePositionTest,
UpdateServerFieldsFromUpdateTest) {
Yes, exactly so.
The commit https://codereview.chromium.org/283143002 fix crashes with invalid
data from server and add unittest for both GetUniqueBookmarkTagFromUpdate and
GetUpdatePosition functions. But it checks this function separately, and my
approach is to check whole cycle for receiving and updating unique_position from
server

[reat, 2014-09-04 05:06:30]

Hi all,
add any comments and blank lines

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
sync/engine/syncer_util_unittest.cc:161: // Checks that whole cycle of
unique_position updating from
I've added some comments what this tests check

[Nicolas Zea, 2014-09-04 18:44:38]

lgtm

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
sync/engine/syncer_util_unittest.cc:164: InitSuffixIngredients();  // Initialize
update with valid data
nit: Comments should have proper punctuation. Add a period at the end of this
comment, and the other comments below.

[reat, 2014-09-05 04:42:55]

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/533113002/diff/20001/sync/engine/syncer_util_...
sync/engine/syncer_util_unittest.cc:164: InitSuffixIngredients();  // Initialize
update with valid data
On 2014/09/04 18:44:37, Nicolas Zea wrote:
> nit: Comments should have proper punctuation. Add a period at the end of this
> comment, and the other comments below.
Fixed

[reat, 2014-09-05 04:43:06]

The CQ bit was checked by reat@yandex-team.ru

[commit-bot: I haz the power, 2014-09-05 04:47:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reat@yandex-team.ru/533113002/40001

[commit-bot: I haz the power, 2014-09-05 08:18:15]

Committed patchset #3 (id:40001) as cabcbe147db45ccb1c41925c26c06b2256d2460a

[commit-bot: I haz the power, 2014-09-10 03:37:54]

Patchset 3 (id:??) landed as
https://crrev.com/94652f8ec61803b7a6988c9343089068934954d2
Cr-Commit-Position: refs/heads/master@{#293473}