src/compiler/js-typed-lowering.cc - Issue 533103002: Fix typed lowering of JSToBoolean on number inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 533103002: Fix typed lowering of JSToBoolean on number inputs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Extend test to cover this case. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 6fad5ab6033527d76d069295c7c7c8e81f95dc1f..772ab0e082a410d28c33e20902e3098726c0dab0 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -491,10 +491,7 @@ Reduction JSTypedLowering::ReduceJSToBooleanInput(Node* input) {

Node* cmp = graph()->NewNode(simplified()->NumberEqual(), input,

jsgraph()->ZeroConstant());

Node* inv = graph()->NewNode(simplified()->BooleanNot(), cmp);

- ReplaceEagerly(input, inv);

- // TODO(titzer): Ugly. ReplaceEagerly smashes all uses. Smash it back here.

- cmp->ReplaceInput(0, input);

- return Changed(inv);

+ return ReplaceWith(inv);

}

// TODO(turbofan): js-typed-lowering of ToBoolean(string)

return NoChange();