Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/instruction-selector.cc

Issue 533083002: [turbofan] Finish nodes are always marked as references. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/instruction-selector-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction-selector.cc
diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc
index 0e3f341f4f2a1c16d88e4deece82138e7dc4bc27..a530824f956199345d08a846f109c4fad79f70e1 100644
--- a/src/compiler/instruction-selector.cc
+++ b/src/compiler/instruction-selector.cc
@@ -199,11 +199,10 @@ void InstructionSelector::MarkAsDouble(Node* node) {
DCHECK(!IsReference(node));
sequence()->MarkAsDouble(node->id());
- // Propagate "doubleness" throughout Finish/Phi nodes.
+ // Propagate "doubleness" throughout Phi nodes.
for (UseIter i = node->uses().begin(); i != node->uses().end(); ++i) {
Node* user = *i;
switch (user->opcode()) {
- case IrOpcode::kFinish:
case IrOpcode::kPhi:
if (IsDouble(user)) continue;
MarkAsDouble(user);
@@ -226,11 +225,10 @@ void InstructionSelector::MarkAsReference(Node* node) {
DCHECK(!IsDouble(node));
sequence()->MarkAsReference(node->id());
- // Propagate "referenceness" throughout Finish/Phi nodes.
+ // Propagate "referenceness" throughout Phi nodes.
for (UseIter i = node->uses().begin(); i != node->uses().end(); ++i) {
Node* user = *i;
switch (user->opcode()) {
- case IrOpcode::kFinish:
case IrOpcode::kPhi:
if (IsReference(user)) continue;
MarkAsReference(user);
@@ -482,7 +480,7 @@ void InstructionSelector::VisitNode(Node* node) {
// No code needed for these graph artifacts.
return;
case IrOpcode::kFinish:
- return VisitFinish(node);
+ return MarkAsReference(node), VisitFinish(node);
case IrOpcode::kParameter: {
LinkageLocation location =
linkage()->GetParameterLocation(OpParameter<int>(node));
« no previous file with comments | « no previous file | src/compiler/instruction-selector-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698