Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 533073004: HPACK: Split header fields in encoder. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Johnny
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HPACK: Split header fields in encoder. Since '\0' delimited concatenation of header field values is not allowed any more in HTTP/2 draft-14, but servers might prepare such headers, the HPACK encoder should split them into multiple headers with identical names. This lands server change 74384948 by bnc. BUG=400336 Committed: https://crrev.com/fc3abecc8ddcde3d2bf2661c7def2d12ce71fc80 Cr-Commit-Position: refs/heads/master@{#293537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -6 lines) Patch
M net/spdy/hpack_encoder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M net/spdy/hpack_round_trip_test.cc View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL
6 years, 3 months ago (2014-09-04 15:10:01 UTC) #2
Johnny
lgtm
6 years, 3 months ago (2014-09-04 16:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/533073004/1
6 years, 3 months ago (2014-09-05 15:41:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8d5b75cdfe23eda6cdd4c0bf9e63e81f224c0146
6 years, 3 months ago (2014-09-05 16:53:17 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc3abecc8ddcde3d2bf2661c7def2d12ce71fc80
Cr-Commit-Position: refs/heads/master@{#293537}

Powered by Google App Engine
This is Rietveld 408576698