Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 533073003: Force layout to make a track rendering test non-flaky (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Force layout to make a track rendering test non-flaky While !textTracksAreReady(), readyState is constrained to HAVE_CURRENT_DATA or lower. Once text tracks are ready, if the media load has already progressed far, the canplaythrough event dispatch and the text track rendering will be racy. Since the rendering is not observable to Web content, it does not seem worthwhile trying to make this deterministic. The same fix was applied to WebKit: http://trac.webkit.org/changeset/148050/trunk/LayoutTests/media/track/track-cue-container-rendering-position.html BUG=330049 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181310

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/track/track-cue-container-rendering-position.html View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
6 years, 3 months ago (2014-09-03 09:39:12 UTC) #2
fs
lgtm https://codereview.chromium.org/533073003/diff/1/LayoutTests/media/track/track-cue-container-rendering-position.html File LayoutTests/media/track/track-cue-container-rendering-position.html (right): https://codereview.chromium.org/533073003/diff/1/LayoutTests/media/track/track-cue-container-rendering-position.html#newcode24 LayoutTests/media/track/track-cue-container-rendering-position.html:24: testExpected("cueDisplayElement.offsetTop > (video.videoHeight * .75)", true); Any idea ...
6 years, 3 months ago (2014-09-03 10:33:02 UTC) #3
philipj_slow
https://codereview.chromium.org/533073003/diff/1/LayoutTests/media/track/track-cue-container-rendering-position.html File LayoutTests/media/track/track-cue-container-rendering-position.html (right): https://codereview.chromium.org/533073003/diff/1/LayoutTests/media/track/track-cue-container-rendering-position.html#newcode24 LayoutTests/media/track/track-cue-container-rendering-position.html:24: testExpected("cueDisplayElement.offsetTop > (video.videoHeight * .75)", true); On 2014/09/03 10:33:02, ...
6 years, 3 months ago (2014-09-03 11:31:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/533073003/1
6 years, 3 months ago (2014-09-03 11:33:04 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 12:20:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181310

Powered by Google App Engine
This is Rietveld 408576698