Only draw the overhang pattern on overhang areas.

Only draw the overhang pattern on overhang areas.

Split the draw gutter quads into two regions -- one to be drawn with
the overhang texture and the other to be drawn with the the background
color.

BUG=314767
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233380

[ccameron, 2013-11-05 00:39:11]

This does it -- and it fixes the layout tests (which fortunately are still
marked as failing, so I don't have to stage with layout test changes).

[enne (OOO), 2013-11-05 01:05:17]

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc#n...
cc/trees/layer_tree_impl.cc:248:
gfx::Rect(root_scroll_layer_->content_bounds()));
I think this should do the same thing as ScrollableSize, aka
root_scroll_layer_->children()[0].

If it's the case that the root scroll layer is always sized correctly, then we
should just use the root_scroll_layer_->bounds() in ScrollableSize too.

(aelias, do you remember what the state of this is?)

[aelias_OOO_until_Jul13, 2013-11-05 01:15:17]

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc#n...
cc/trees/layer_tree_impl.cc:248:
gfx::Rect(root_scroll_layer_->content_bounds()));
On 2013/11/05 01:05:17, enne wrote:
> I think this should do the same thing as ScrollableSize, aka
> root_scroll_layer_->children()[0].
> 
> If it's the case that the root scroll layer is always sized correctly, then we
> should just use the root_scroll_layer_->bounds() in ScrollableSize too.
> 
> (aelias, do you remember what the state of this is?)

As far as I know, the Blink bug causing that to occasionally be empty is still
not fixed (unless it went away on its own in the general Blink churn).  It would
be better to call ScrollableSize() here.  But even better would be to use
RootContainerLayer().bounds() I think?  Those would not need to be transformed.

[ccameron, 2013-11-05 01:15:20]

Thanks!

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/53303006/diff/1/cc/trees/layer_tree_impl.cc#n...
cc/trees/layer_tree_impl.cc:248:
gfx::Rect(root_scroll_layer_->content_bounds()));
On 2013/11/05 01:05:17, enne wrote:
> I think this should do the same thing as ScrollableSize, aka
> root_scroll_layer_->children()[0].
> 
> If it's the case that the root scroll layer is always sized correctly, then we
> should just use the root_scroll_layer_->bounds() in ScrollableSize too.
> 
> (aelias, do you remember what the state of this is?)

Okay -- updated to use root scroll layer's first child. It seemed to be the
right size when I looked at it.

[enne (OOO), 2013-11-05 01:55:54]

> As far as I know, the Blink bug causing that to occasionally be empty is still
> not fixed (unless it went away on its own in the general Blink churn).  It
would
> be better to call ScrollableSize() here.  But even better would be to use
> RootContainerLayer().bounds() I think?  Those would not need to be
transformed.

I think in this case the root container layer is the entire viewport and the
overhang needs to differentiate inside of that what is covered by the scrolling
contents and what is not.  Similarly, I think ScrollableSize is not sufficient
and this needs to be a screenspace rect.

[enne (OOO), 2013-11-05 01:58:15]

lgtm

[aelias_OOO_until_Jul13, 2013-11-05 01:58:15]

On 2013/11/05 01:55:54, enne wrote:
> > As far as I know, the Blink bug causing that to occasionally be empty is
still
> > not fixed (unless it went away on its own in the general Blink churn).  It
> would
> > be better to call ScrollableSize() here.  But even better would be to use
> > RootContainerLayer().bounds() I think?  Those would not need to be
> transformed.
> 
> I think in this case the root container layer is the entire viewport and the
> overhang needs to differentiate inside of that what is covered by the
scrolling
> contents and what is not.  Similarly, I think ScrollableSize is not sufficient
> and this needs to be a screenspace rect.

OK, I thought maybe the overscroll was applied as a transform above the root
container layer.  If it's applied as a transform on the scroll layer, then this
is fine (modulo the nit of calling ScrollableSize() walking to the child
yourself).

[ccameron, 2013-11-05 17:07:04]

Thanks!!

[commit-bot: I haz the power, 2013-11-05 17:13:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/53303006/70001

[commit-bot: I haz the power, 2013-11-05 17:38:42]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-11-05 21:48:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/53303006/70001

[commit-bot: I haz the power, 2013-11-06 02:16:21]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 19:31:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/53303006/70001

[commit-bot: I haz the power, 2013-11-06 21:44:13]

Change committed as 233380