Source/core/html/HTMLFrameElementBase.cpp - Issue 53303002: Have HTMLFrameOwnerElement / SubframeLoadingDisabler deal with references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 53303002: Have HTMLFrameOwnerElement / SubframeLoadingDisabler deal with references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tiny fix Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFrameElementBase.cpp

diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp

index 2e7fcdeef118fe86ade614b8fa9a9adaf928bc13..be9512e5087729ee44725c153d3c25677a51eb1b 100644

--- a/Source/core/html/HTMLFrameElementBase.cpp

+++ b/Source/core/html/HTMLFrameElementBase.cpp

@@ -153,7 +153,7 @@ void HTMLFrameElementBase::didNotifySubtreeInsertionsToDocument()

if (!document().frame())

return;

- if (!SubframeLoadingDisabler::canLoadFrame(this))

+ if (!SubframeLoadingDisabler::canLoadFrame(*this))

return;

setNameAndOpenURL();

« no previous file with comments | « Source/core/frame/Frame.cpp ('k') | Source/core/html/HTMLFrameOwnerElement.h » ('j') | no next file with comments »