Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 533013002: Revert of Convert chrome_unscaled_resources to use a qualified path. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert chrome_unscaled_resources to use a qualified path. (patchset #1 id:1 of https://codereview.chromium.org/534013002/) Reason for revert: Linux_x64 says: ninja: error: 'gen/chrome/chrome_unscaled_resources.pak', needed by 'gen/repack/resources.pak', missing and no known rule to make it Original issue's description: > Convert chrome_unscaled_resources to use a qualified path. > > BUG=401588 > > Committed: https://chromium.googlesource.com/chromium/src/+/01ac77c0ca2f552d4ff44d5f16dad8844eccd516 TBR=thakis@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=401588 Committed: https://crrev.com/8416a6b92504d4e1a3ca183a505b59885d2f3b61 Cr-Commit-Position: refs/heads/master@{#293059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/app/theme/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_component_extension_resource_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Created Revert of Convert chrome_unscaled_resources to use a qualified path.
6 years, 3 months ago (2014-09-03 02:47:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/533013002/1
6 years, 3 months ago (2014-09-03 02:48:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as fbd7f63fb681fc2311677e5445337db30703546d
6 years, 3 months ago (2014-09-03 02:49:52 UTC) #3
Nico
Ah, because of https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_repack_resources.gypi&l=8 Not sure why the trybot didn't see this though.
6 years, 3 months ago (2014-09-03 03:10:47 UTC) #4
tfarina
lgtm (rubber-stamp)
6 years, 3 months ago (2014-09-03 17:57:51 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8416a6b92504d4e1a3ca183a505b59885d2f3b61
Cr-Commit-Position: refs/heads/master@{#293059}

Powered by Google App Engine
This is Rietveld 408576698