Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/data_reduction_proxy.gypi

Issue 533003002: Use chromium version for data reduction proxy version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added needed file Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy.gypi
diff --git a/components/data_reduction_proxy.gypi b/components/data_reduction_proxy.gypi
index 9be6ed7fd45411fc6edb25350ba1a79773fcb44c..42ff0d28cdf43becf00f62286992b5f0a41c0409 100644
--- a/components/data_reduction_proxy.gypi
+++ b/components/data_reduction_proxy.gypi
@@ -10,6 +10,7 @@
'target_name': 'data_reduction_proxy_browser',
'type': 'static_library',
'dependencies': [
+ 'data_reduction_proxy_version_header',
'../base/base.gyp:base',
'../crypto/crypto.gyp:crypto',
'../net/net.gyp:net',
@@ -86,6 +87,39 @@
'data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h',
],
},
+ {
+ 'target_name': 'data_reduction_proxy_version_header',
marq (ping after 24h) 2014/09/10 07:44:55 I'm assuming that this roundabout mechanism for ge
bengr 2014/09/10 08:14:13 I'm not sure how to act on this comment. Yes, the
+ 'type': 'none',
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(SHARED_INTERMEDIATE_DIR)',
+ ],
+ },
+ 'actions': [
+ {
+ 'action_name': 'version_header',
+ 'message': 'Generating version header file: <@(_outputs)',
+ 'inputs': [
+ '<(version_path)',
+ 'data_reduction_proxy/common/version.h.in',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/components/data_reduction_proxy/common/version.h',
+ ],
+ 'action': [
+ 'python',
+ '<(version_py_path)',
+ '-e', 'VERSION_FULL="<(version_full)"',
+ 'data_reduction_proxy/common/version.h.in',
+ '<@(_outputs)',
+ ],
+ 'includes': [
+ '../build/util/version.gypi',
+ ],
+ },
+ ],
+ },
+
],
}

Powered by Google App Engine
This is Rietveld 408576698