Use chromium version for data reduction proxy version

Use chromium version for data reduction proxy version

Provide a method to get the chromium version for use as the
data reduction proxy version.

BUG=410127
Committed: https://crrev.com/224a36ccd83363bed8a975f43f338aec68054768
Cr-Commit-Position: refs/heads/master@{#295906}

[bengr, 2014-09-03 01:37:47]

bengr@chromium.org changed reviewers:
+ marq@chromium.org, sgurun@chromium.org

[bengr, 2014-09-03 01:37:47]

Selim: android_webview
Mark: everything else

[sgurun-gerrit only, 2014-09-03 22:07:53]

https://codereview.chromium.org/533003002/diff/1/android_webview/browser/net/...
File android_webview/browser/net/aw_url_request_context_getter.cc (left):

https://codereview.chromium.org/533003002/diff/1/android_webview/browser/net/...
android_webview/browser/net/aw_url_request_context_getter.cc:235:
data_reduction_proxy::kAndroidWebViewProtocolVersion,
I don't think there is any other usage of this constant. Please remove it where
ever it is defined.

[sgurun-gerrit only, 2014-09-03 23:57:35]

On 2014/09/03 22:07:53, sgurun_OOO_until_Oct5 wrote:
>
https://codereview.chromium.org/533003002/diff/1/android_webview/browser/net/...
> File android_webview/browser/net/aw_url_request_context_getter.cc (left):
> 
>
https://codereview.chromium.org/533003002/diff/1/android_webview/browser/net/...
> android_webview/browser/net/aw_url_request_context_getter.cc:235:
> data_reduction_proxy::kAndroidWebViewProtocolVersion,
> I don't think there is any other usage of this constant. Please remove it
where
> ever it is defined.

aw lgtm after addressing my concern above

[marq (ping after 24h), 2014-09-10 07:44:56]

https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
File components/data_reduction_proxy.gypi (right):

https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
components/data_reduction_proxy.gypi:91: 'target_name':
'data_reduction_proxy_version_header',
I'm assuming that this roundabout mechanism for getting the version is
necessitated by componentization? The regular Chrome API for getting the version
number (or the header where it's defined) has pernicious dependencies?

This still seems really roundabout and hacky, though.

[bengr, 2014-09-10 08:14:13]

https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
File components/data_reduction_proxy.gypi (right):

https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
components/data_reduction_proxy.gypi:91: 'target_name':
'data_reduction_proxy_version_header',
On 2014/09/10 07:44:55, marq_ wrote:
> I'm assuming that this roundabout mechanism for getting the version is
> necessitated by componentization? The regular Chrome API for getting the
version
> number (or the header where it's defined) has pernicious dependencies?
> 
> This still seems really roundabout and hacky, though.

I'm not sure how to act on this comment. Yes, the path to version info is well
trodden through chrome/, but some features do things like this. I don't think
this is hacky. This is the way the data reduction proxy will version, so it
makes sense to define it here.

[marq (ping after 24h), 2014-09-11 08:33:45]

On 2014/09/10 08:14:13, bengr1 wrote:
>
https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
> File components/data_reduction_proxy.gypi (right):
> 
>
https://codereview.chromium.org/533003002/diff/20001/components/data_reductio...
> components/data_reduction_proxy.gypi:91: 'target_name':
> 'data_reduction_proxy_version_header',
> On 2014/09/10 07:44:55, marq_ wrote:
> > I'm assuming that this roundabout mechanism for getting the version is
> > necessitated by componentization? The regular Chrome API for getting the
> version
> > number (or the header where it's defined) has pernicious dependencies?
> > 
> > This still seems really roundabout and hacky, though.
> 
> I'm not sure how to act on this comment. Yes, the path to version info is well
> trodden through chrome/, but some features do things like this. I don't think
> this is hacky. This is the way the data reduction proxy will version, so it
> makes sense to define it here.

Okay, I see other places where this pattern is used. It seems odd to have
multiple header files defining
PRODUCT_VERSION, and to go to the trouble of creating a new build target just
for this purpose. I see
that VersionInfo::Version() is encumbered by various platform-specific
complexities, but maybe a cleaner
solution in general is to have a base/ or build/ .h file that defines
PRODUCT_VERSION (etc) in a single place
for any component, extension, or chunk of chrome/ code to use, so we don't have
the data reduction 
component and the chromecast code, and the extension shell all separately
generating a header for that 
purpose.

That said, I don't see that as a blocker for this CL. At this stage my only
object is that reading the code
in isolation, it seems strange to be defining a global macro symbol with a name
like PRODUCT_VERSION
inside a component like this. Maybe add a TODO to consolidate all definitions of
PRODUCT_VERSION 
(you can put my name on it if you want).

[marq (ping after 24h), 2014-09-11 08:33:50]

lgtm

[bengr, 2014-09-12 20:37:28]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-09-12 20:38:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/533003002/20001

[commit-bot: I haz the power, 2014-09-12 20:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 20:56:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55455)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/60354)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bengr, 2014-09-18 22:47:54]

Patchset #4 (id:60001) has been deleted

[bengr, 2014-09-18 22:51:38]

bengr@chromium.org changed reviewers:
+ benm@chromium.org, mmenke@chromium.org

[bengr, 2014-09-18 22:51:39]

mmenke: io_thread, profile_*
benm: webview. sgurun gave an lgtm, but things changed a bit.
marq: drp. I changed things around. PTA second L.

[mmenke, 2014-09-18 22:53:18]

On 2014/09/18 22:51:39, bengr1 wrote:
> mmenke: io_thread, profile_*
> benm: webview. sgurun gave an lgtm, but things changed a bit.
> marq: drp. I changed things around. PTA second L.

io_thread, profiles/ LGTM

[benm (inactive), 2014-09-19 16:14:22]

a_w lgtm

[bengr, 2014-09-20 00:56:24]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/533003002/100001

[commit-bot: I haz the power, 2014-09-20 00:58:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/533003002/100001

[commit-bot: I haz the power, 2014-09-20 01:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 01:20:40]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bengr, 2014-09-20 02:12:33]

Patchset #6 (id:120001) has been deleted

[bengr, 2014-09-21 17:20:24]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-09-21 17:21:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/533003002/140001

[commit-bot: I haz the power, 2014-09-21 17:44:07]

Committed patchset #6 (id:140001) as e18ce2b3fc9c308549b5db63edf152e409b82ee0

[commit-bot: I haz the power, 2014-09-21 17:44:44]

Patchset 6 (id:??) landed as
https://crrev.com/224a36ccd83363bed8a975f43f338aec68054768
Cr-Commit-Position: refs/heads/master@{#295906}