Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 533001: Linux: reenable malloc overrides. (Closed)

Created:
10 years, 11 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, willchan no longer on Chromium, vandebo (ex-Chrome), Chris Evans, brettw+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Linux: reenable malloc overrides. (These were disabled in r35804 and r35810.) This time we are using the __libc_* names to get at the real glibc functions rather than dlsym. This now means that code that calls __libc_* gets the raw functions, not 'safe' ones. Also, this sets the visibility correctly. Previously we were not overriding malloc calls made in shared libraries. BUG=31809 TEST=Covered by unittests.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing evan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -107 lines) Patch
M base/process_util_linux.cc View 1 2 chunks +49 lines, -66 lines 0 comments Download
M base/process_util_unittest.cc View 4 chunks +11 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agl
10 years, 11 months ago (2010-01-08 20:20:21 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/533001/diff/1/2 File base/process_util_linux.cc (right): http://codereview.chromium.org/533001/diff/1/2#newcode539 base/process_util_linux.cc:539: // for this in process_util_unittest.cc trailing period http://codereview.chromium.org/533001/diff/1/2#newcode552 ...
10 years, 11 months ago (2010-01-08 20:23:49 UTC) #2
agl
10 years, 11 months ago (2010-01-08 21:24:12 UTC) #3
http://codereview.chromium.org/533001/diff/1/2
File base/process_util_linux.cc (right):

http://codereview.chromium.org/533001/diff/1/2#newcode539
base/process_util_linux.cc:539: // for this in process_util_unittest.cc
On 2010/01/08 20:23:49, Evan Martin wrote:
> trailing period

Done.

Powered by Google App Engine
This is Rietveld 408576698