Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 532973002: Do not return a homepage URL for shared modules (Closed)

Created:
6 years, 3 months ago by elijahtaylor1
Modified:
6 years, 3 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not return a homepage URL for shared modules This keeps the "Visit Website" link from showing up in chrome://extensions, which makes sense because shared modules are automatically installed. BUG=408927 Committed: https://crrev.com/58dac2245f1a7076bb46f9ad6b409397b7b3cb27 Cr-Commit-Position: refs/heads/master@{#293203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/common/extensions/manifest_url_handler.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
elijahtaylor1
6 years, 3 months ago (2014-09-02 23:31:39 UTC) #2
miket_OOO
lgtm
6 years, 3 months ago (2014-09-03 18:01:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/532973002/1
6 years, 3 months ago (2014-09-03 18:26:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 67a20c2f45e2ab13dc33cef63e8881dfabaaf11a
6 years, 3 months ago (2014-09-03 21:46:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58dac2245f1a7076bb46f9ad6b409397b7b3cb27
Cr-Commit-Position: refs/heads/master@{#293203}

Powered by Google App Engine
This is Rietveld 408576698