Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 532903002: Docserver: Convert more future Get calls to Thens (Closed)

Created:
6 years, 3 months ago by gpdavis
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, ahernandez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Convert more future Get calls to Thens BUG=306341 NOTRY=True Committed: https://crrev.com/9fd2631a8f318be093277cc4792f07a27394d28c Cr-Commit-Position: refs/heads/master@{#293543}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -78 lines) Patch
M chrome/common/extensions/docs/server2/features_bundle.py View 2 chunks +72 lines, -64 lines 0 comments Download
M chrome/common/extensions/docs/server2/new_github_file_system.py View 1 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/server2/path_canonicalizer.py View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ahernandez
lgtm with comment. https://codereview.chromium.org/532903002/diff/1/chrome/common/extensions/docs/server2/new_github_file_system.py File chrome/common/extensions/docs/server2/new_github_file_system.py (right): https://codereview.chromium.org/532903002/diff/1/chrome/common/extensions/docs/server2/new_github_file_system.py#newcode197 chrome/common/extensions/docs/server2/new_github_file_system.py:197: return github_future.Then(resolve) Inline github_future.
6 years, 3 months ago (2014-09-03 19:12:37 UTC) #2
ahernandez
and a couple nits https://codereview.chromium.org/532903002/diff/1/chrome/common/extensions/docs/server2/new_github_file_system.py File chrome/common/extensions/docs/server2/new_github_file_system.py (right): https://codereview.chromium.org/532903002/diff/1/chrome/common/extensions/docs/server2/new_github_file_system.py#newcode181 chrome/common/extensions/docs/server2/new_github_file_system.py:181: def resolve(github_zip): Nit: more descriptive ...
6 years, 3 months ago (2014-09-03 19:16:08 UTC) #3
gpdavis
yoz@chromium.org, PTAL
6 years, 3 months ago (2014-09-03 23:45:44 UTC) #5
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-05 01:29:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/532903002/20001
6 years, 3 months ago (2014-09-05 01:32:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5553)
6 years, 3 months ago (2014-09-05 06:09:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/532903002/20001
6 years, 3 months ago (2014-09-05 16:37:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/532903002/20001
6 years, 3 months ago (2014-09-05 17:16:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3e931a73f4f18a9aa9ba61a7f32caf9241a2130a
6 years, 3 months ago (2014-09-05 17:18:14 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:17 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9fd2631a8f318be093277cc4792f07a27394d28c
Cr-Commit-Position: refs/heads/master@{#293543}

Powered by Google App Engine
This is Rietveld 408576698