Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 532883003: Fix and enable WebViewInteractiveTest.Focus_InputMethod (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and enable WebViewInteractiveTest.Focus_InputMethod There were couple issues that were fixed: 1. If oninput listener fires before the guest is requested to "wait for oninput", we would timeout. This is taken care of by a flag. 2. TextInputClient::SetCompositionText() call sends an IPC to the renderer/, if the next JavaScript step runs before the IPC is sent then that would fail the test. This is taken care of by sending executing empty JavaScript code on the embedder. BUG=387956 Test=Internal test only change, nothing visible. Committed: https://crrev.com/f69da7c88e832aa7751d5756c7beff3e183e905f Cr-Commit-Position: refs/heads/master@{#293341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M chrome/browser/apps/web_view_interactive_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js View 3 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lazyboy
6 years, 3 months ago (2014-09-03 23:34:16 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-04 16:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/532883003/1
6 years, 3 months ago (2014-09-04 16:16:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/6010)
6 years, 3 months ago (2014-09-04 19:25:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/532883003/1
6 years, 3 months ago (2014-09-04 19:30:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 92b29f34444e2a7fb2d90eea3dbc861d5336613b
6 years, 3 months ago (2014-09-04 21:37:29 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f69da7c88e832aa7751d5756c7beff3e183e905f
Cr-Commit-Position: refs/heads/master@{#293341}

Powered by Google App Engine
This is Rietveld 408576698