Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 532873002: ozone: gbm: Fail earlier if device can't be opened (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: gbm: Fail earlier if device can't be opened This crashes inside GbmBuffer::CreateBuffer due to NULL gbm_device. We should check this earlier for a more informative crash. BUG=410002 TEST=run chrome on link_freon NOTRY=true Committed: https://crrev.com/dd209e8c17ceb01fb575ce9701c056178e364729 Cr-Commit-Position: refs/heads/master@{#293175}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M ui/ozone/platform/dri/dri_wrapper.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 3 months ago (2014-09-02 20:34:06 UTC) #2
dnicoara
lgtm
6 years, 3 months ago (2014-09-02 20:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/532873002/20001
6 years, 3 months ago (2014-09-03 17:17:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6b919af1f30d2dce1ecb8bcc4a797c48a09dd3a5
6 years, 3 months ago (2014-09-03 18:25:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:27:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd209e8c17ceb01fb575ce9701c056178e364729
Cr-Commit-Position: refs/heads/master@{#293175}

Powered by Google App Engine
This is Rietveld 408576698