Adding support for forced URLs to TopSites.

chrome/browser/history/top_sites_cache_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/top_sites_cache.h"
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace history {
 
 namespace {
 
 class TopSitesCacheTest : public testing::Test {
  public:
   TopSitesCacheTest() {
   }
 
  protected:
-  // Initializes |top_sites_| and |cache_| based on |spec|, which is a list of
-  // URL strings with optional indents: indentated URLs redirect to the last
-  // non-indented URL. Titles are assigned as "Title 1", "Title 2", etc., in the
-  // order of appearance. See |kTopSitesSpecBasic| for an example.
+  // Initializes |top_sites_| on |spec|, which is a list of URL strings with
+  // optional indents: indentated URLs redirect to the last non-indented URL.
+  // Titles are assigned as "Title 1", "Title 2", etc., in the order of
+  // appearance. See |kTopSitesSpecBasic| for an example. This function does not
+  // update |cache_| so you can manipulate |top_sites_| before you update it.
+  void BuildTopSites(const char** spec, size_t size);
+
+  // Initializes |top_sites_| and |cache_| based on |spec|.
   void InitTopSiteCache(const char** spec, size_t size);
 
   MostVisitedURLList top_sites_;
   TopSitesCache cache_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TopSitesCacheTest);
 };
 
-void TopSitesCacheTest::InitTopSiteCache(const char** spec, size_t size) {
+void TopSitesCacheTest::BuildTopSites(const char** spec, size_t size) {
   std::set<std::string> urls_seen;
   for (size_t i = 0; i < size; ++i) {
     const char* spec_item = spec[i];
     while (*spec_item && *spec_item == ' ')  // Eat indent.
       ++spec_item;
     if (urls_seen.find(spec_item) != urls_seen.end())
       NOTREACHED() << "Duplicate URL found: " << spec_item;
     urls_seen.insert(spec_item);
     if (spec_item == spec[i]) {  // No indent: add new MostVisitedURL.
       string16 title(ASCIIToUTF16("Title ") +
                      base::Uint64ToString16(top_sites_.size() + 1));
       top_sites_.push_back(MostVisitedURL(GURL(spec_item), title));
     }
     ASSERT_TRUE(!top_sites_.empty());
     // Set up redirect to canonical URL. Canonical URL redirects to itself, too.
     top_sites_.back().redirects.push_back(GURL(spec_item));
   }
+}
+
+void TopSitesCacheTest::InitTopSiteCache(const char** spec, size_t size) {
+  BuildTopSites(spec, size);
   cache_.SetTopSites(top_sites_);
 }
 
 const char* kTopSitesSpecBasic[] = {
   "http://www.google.com",
   "  http://www.gogle.com",  // Redirects.
   "  http://www.gooogle.com",  // Redirects.
   "http://www.youtube.com/a/b",
   "  http://www.youtube.com/a/b?test=1",  // Redirects.
   "https://www.google.com/",
@@ skipping 202 matching lines @@
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     std::string expected(test_cases[i].expected);
     std::string query(test_cases[i].query);
     GURL result1(cache_.GetSpecializedCanonicalURL(GURL(query)));
     EXPECT_EQ(expected, result1.spec()) << " for test_case[" << i << "]";
     GURL result2(cache_.GetGeneralizedCanonicalURL(GURL(query)));
     EXPECT_EQ(expected, result2.spec()) << " for test_case[" << i << "]";
   }
 }
 
+// This test ensures forced URLs behave in the expected way.
+TEST_F(TopSitesCacheTest, CacheForcedURLs) {
+  // Forced URLs must always appear at the beginning of the list.
+  BuildTopSites(kTopSitesSpecBasic, arraysize(kTopSitesSpecBasic));
+  top_sites_[0].last_forced_time = base::Time::FromJsTime(1000);
+  top_sites_[1].last_forced_time =  base::Time::FromJsTime(2000);
+  cache_.SetTopSites(top_sites_);
+
+  EXPECT_EQ(2u, cache_.GetNbForcedURLs());
+  EXPECT_EQ(2u, cache_.GetNbNonForcedURLs());
+}
+
 }  // namespace
 
 }  // namespace history