Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

Issue 53283003: Added UMA stat for tracking accidental navigations on double tap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
index ea58f094cbbd653757d641b14ee0410aedb7d321..c326d1c1b5e6fc30a94926f9d48d5c1cffd2d543 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
@@ -224,7 +224,11 @@ public abstract class TabBase implements NavigationClient {
* Goes to the navigation entry before the current one.
*/
public void goBack() {
- if (mContentViewCore != null) mContentViewCore.goBack();
+ if (mContentViewCore != null) {
+ mContentViewCore.reportActionAfterDoubleTapUMA(
+ ContentViewCore.UMAActionAfterDoubleTap.NAVIGATE_BACK);
+ mContentViewCore.goBack();
+ }
}
/**
@@ -335,7 +339,11 @@ public abstract class TabBase implements NavigationClient {
/** Stop the current navigation. */
public void stopLoading() {
- if (mContentViewCore != null) mContentViewCore.stopLoading();
+ if (mContentViewCore != null) {
+ mContentViewCore.reportActionAfterDoubleTapUMA(
+ ContentViewCore.UMAActionAfterDoubleTap.NAVIGATE_STOP);
+ mContentViewCore.stopLoading();
+ }
}
/**
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.h » ('j') | content/browser/android/content_view_core_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698