Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

Issue 53283003: Added UMA stat for tracking accidental navigations on double tap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
index 08c42218641dd5f81b5b74146a5db92564ea9d73..89eaad2f240ad3b766b89db6d030a25528f823d3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
@@ -221,7 +221,11 @@ public abstract class TabBase implements NavigationClient {
* Goes to the navigation entry before the current one.
*/
public void goBack() {
- if (mContentViewCore != null) mContentViewCore.goBack();
+ if (mContentViewCore != null) {
+ mContentViewCore.updateActionAfterDoubleTapUMA(
Rick Byers 2013/10/31 17:53:10 since this is pretty general (has nothing to do wi
bokan 2013/10/31 22:31:58 Changed to reportActionForUMA
+ ContentViewCore.ActionAfterDoubleTap.NAVIGATE_BACK);
+ mContentViewCore.goBack();
+ }
}
/**
@@ -332,7 +336,11 @@ public abstract class TabBase implements NavigationClient {
/** Stop the current navigation. */
public void stopLoading() {
- if (mContentViewCore != null) mContentViewCore.stopLoading();
+ if (mContentViewCore != null) {
+ mContentViewCore.updateActionAfterDoubleTapUMA(
+ ContentViewCore.ActionAfterDoubleTap.NAVIGATE_STOP);
+ mContentViewCore.stopLoading();
+ }
}
/**
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.h » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698