Added UMA stat for tracking accidental navigations on double tap.

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "cc/layers/layer.h"
 #include "cc/output/begin_frame_args.h"
 #include "content/browser/android/interstitial_page_delegate_android.h"
 #include "content/browser/android/load_url_params.h"
 #include "content/browser/android/touch_point.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
@@ skipping 1589 matching lines @@
     // If it was actually enabled globally, enable it for this RenderWidget now.
     if (accessibility_state->IsAccessibleBrowser() && host_impl)
       host_impl->SetAccessibilityMode(AccessibilityModeComplete);
   } else {
     accessibility_state->DisableAccessibility();
     if (host_impl)
       host_impl->SetAccessibilityMode(AccessibilityModeOff);
   }
 }
 
+void ContentViewCoreImpl::SendSingleTapUma(
+    JNIEnv* env,

[Alexei Svitkine (slow), 2013/11/02 00:12:39]

Nit: move this to the line above and align the other args, same for the function
below.

[bokan, 2013/11/04 20:01:08]

Done.

+    jobject obj,
+    int type,
+    int count) {
+  UMA_HISTOGRAM_ENUMERATION("Event.SingleTapType",
+    type, count);

[Alexei Svitkine (slow), 2013/11/02 00:12:39]

Nit: These can fit on the previous line.

[bokan, 2013/11/04 20:01:08]

Done.

+}
+
+void ContentViewCoreImpl::SendActionAfterDoubleTapUma(
+    JNIEnv* env,
+    jobject obj,
+    int type,
+    bool hasDelay,

[Alexei Svitkine (slow), 2013/11/02 00:12:39]

Nit: has_delay

[bokan, 2013/11/04 20:01:08]

Done.

+    int count) {
+  // This UMA stat tracks a user's action after a double tap within
+  // k seconds (where k == 5 currently). This UMA will tell us if
+  // removing the tap gesture delay will lead to significantly more
+  // accidental navigations after a double tap.
+  if(hasDelay) {

[Alexei Svitkine (slow), 2013/11/02 00:12:39]

Nit: Space after if

[bokan, 2013/11/04 20:01:08]

Done.

+      UMA_HISTOGRAM_ENUMERATION("Event.ActionAfterDoubleTapWithDelay",
+        type, count);

[Alexei Svitkine (slow), 2013/11/02 00:12:39]

Nit: Can these fit on the previous line? If not, this needs to indent 2 more
(same for below).

[bokan, 2013/11/04 20:01:08]

Done.

+  } else {
+      UMA_HISTOGRAM_ENUMERATION("Event.ActionAfterDoubleTapNoDelay",
+        type, count);
+  }
+}
+
 void ContentViewCoreImpl::SendOrientationChangeEventInternal() {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->UpdateScreenInfo(rwhv->GetNativeView());
 
   RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(
       web_contents_->GetRenderViewHost());
   rvhi->SendOrientationChangeEvent(device_orientation_);
 }
 
 // This is called for each ContentView.
 jint Init(JNIEnv* env, jobject obj,
           jboolean hardware_accelerated,
           jint native_web_contents,
           jint view_android,
           jint window_android) {
   ContentViewCoreImpl* view = new ContentViewCoreImpl(
       env, obj, hardware_accelerated,
       reinterpret_cast<WebContents*>(native_web_contents),
       reinterpret_cast<ui::ViewAndroid*>(view_android),
       reinterpret_cast<ui::WindowAndroid*>(window_android));
   return reinterpret_cast<jint>(view);
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content