Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 53283002: Update WebRTC iOS bots for ninja (Closed)

Created:
7 years, 1 month ago by kjellander_chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Update WebRTC iOS bots for ninja When a chromium_revision of http://crrev.com/231658 or later is rolled in WebRTC DEPS, our iOS Debug and Release bots are going to break. Updating the target to use the -iphoneos project files will solve this. Because of this, these masters needs to be restarted to apply this update at the same time as I submit https://webrtc-codereview.appspot.com/3159004 TEST=local compilation succeeds using: cd build/ export PYTHONPATH=$(pwd)/scripts:$(pwd)/site_config:$(pwd)/third_party scripts/slave/runbuild.py --master-dir masters/master.client.webrtc --builder="iOS Debug" --override-brdostep --stepreject=update_scripts --logfile=- BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M masters/master.client.webrtc/master_mac_cfg.py View 1 chunk +2 lines, -2 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
(unsolicited) LGTM
7 years, 1 month ago (2013-10-30 20:27:05 UTC) #1
kjellander_chromium
7 years, 1 month ago (2013-10-31 00:40:19 UTC) #2
ghost stip (do not use)
lgtm
7 years, 1 month ago (2013-10-31 17:29:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/53283002/1
7 years, 1 month ago (2013-11-04 09:26:06 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-04 09:26:50 UTC) #5
Message was sent while issue was closed.
Change committed as 232690

Powered by Google App Engine
This is Rietveld 408576698