Issue 532733002: [Android] Speculative fix for crash during overscroll effect creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 532733002: [Android] Speculative fix for crash during overscroll effect creation (Closed)

Created:
6 years, 3 months ago by jdduke (slow)

Modified:
6 years, 3 months ago

Reviewers:
aelias_OOO_until_Jul13, no sievers

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Speculative fix for crash during overscroll effect creation Crash reports indicate that the WindowAndroid's Compositor may be NULL during |RenderWidgetHostViewAndroid::SetContentViewCore()|. While this is a somewhat surprising result, it is in theory possible and should probably not be fatal. Avoid creating the overscroll effect in this case, instead creating it after the compositor is (re-)attached. BUG=407208 TBR=aelias@chromium.org,sievers@chromium.org Review URL: https://codereview.chromium.org/503813003 Cr-Commit-Position: refs/heads/master@{#291835} (cherry picked from commit 7936233f8fb1bc6a969b24474d0f32d03dd832af)

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_android.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

6 years, 3 months ago (2014-09-02 15:25:09 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as dc0b429 (presubmit
successful).

Expand Messages | Collapse Messages