chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Updated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

index aea39111ffd0f0d4c3915309e71f177a8766518e..be0010bfa872de1d8229a7980f89839ad7c3ca40 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -36,12 +36,11 @@ namespace extensions {

WebRequestRulesRegistry::WebRequestRulesRegistry(

Profile* profile,

- scoped_ptr<RulesCacheDelegate>* cache_delegate)

- : RulesRegistry((cache_delegate ? profile : NULL),

- declarative_webrequest_constants::kOnRequest,

- content::BrowserThread::IO,

- true /*log_storage_init_delay*/,

- cache_delegate),

+ RulesCacheDelegate* cache_delegate)

+ : RulesRegistry(profile,

+ declarative_webrequest_constants::kOnRequest,

+ content::BrowserThread::IO,

+ cache_delegate),

profile_id_(profile) {

if (profile)

extension_info_map_ = ExtensionSystem::Get(profile)->info_map();