chrome/browser/extensions/api/declarative/rules_registry_service.cc - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service.cc

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Updated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service.h ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_service.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service.cc b/chrome/browser/extensions/api/declarative/rules_registry_service.cc

index fd2a4abceb1f8a4d70038a531d74a3c90f5be585..a0685d07e717b3997fba969a0468d2c111716baf 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_service.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_service.cc

@@ -45,10 +45,11 @@ RulesRegistryService::RulesRegistryService(Profile* profile)

RulesRegistryService::~RulesRegistryService() {}

void RulesRegistryService::RegisterDefaultRulesRegistries() {

- scoped_ptr<RulesCacheDelegate> ui_part;

+ scoped_ptr<RulesCacheDelegate> web_request_cache_delegate(

+ new RulesCacheDelegate(true /*log_storage_init_delay*/));

scoped_refptr<WebRequestRulesRegistry> web_request_rules_registry(

- new WebRequestRulesRegistry(profile_, &ui_part));

- ui_parts_of_registries_.push_back(ui_part.release());

+ new WebRequestRulesRegistry(profile_, web_request_cache_delegate.get()));

+ cache_delegates_.push_back(web_request_cache_delegate.release());

RegisterRulesRegistry(web_request_rules_registry);

content::BrowserThread::PostTask(

@@ -57,9 +58,11 @@ void RulesRegistryService::RegisterDefaultRulesRegistries() {

profile_, web_request_rules_registry));

#if defined(ENABLE_EXTENSIONS)

+ scoped_ptr<RulesCacheDelegate> content_rules_cache_delegate(

+ new RulesCacheDelegate(false /*log_storage_init_delay*/));

scoped_refptr<ContentRulesRegistry> content_rules_registry(

- new ContentRulesRegistry(profile_, &ui_part));

- ui_parts_of_registries_.push_back(ui_part.release());

+ new ContentRulesRegistry(profile_, content_rules_cache_delegate.get()));

+ cache_delegates_.push_back(content_rules_cache_delegate.release());

RegisterRulesRegistry(content_rules_registry);

content_rules_registry_ = content_rules_registry.get();