chrome/browser/extensions/api/declarative/rules_registry_service.h - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service.h

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Merge with ToT Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative/rules_registry.cc ('K') | « chrome/browser/extensions/api/declarative/rules_registry.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_service.h

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service.h b/chrome/browser/extensions/api/declarative/rules_registry_service.h

index f4816da9d01e89013f41209a805cfcfbd9e06a55..aa51607d30611e8b999f67cdbe862c87a6db7960 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_service.h

+++ b/chrome/browser/extensions/api/declarative/rules_registry_service.h

@@ -96,7 +96,7 @@ class RulesRegistryService : public ProfileKeyedAPI,

RulesRegistryMap rule_registries_;

// We own the parts of the registries which need to run on the UI thread.

- ScopedVector<RulesCacheDelegate> ui_parts_of_registries_;

+ ScopedVector<RulesCacheDelegate> cache_delegates_;

// Weak pointer into rule_registries_ to make it easier to handle content rule

// conditions.