Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 532703004: Remove legacy (and also broken) SkPicture constructor. (Closed)

Created:
6 years, 3 months ago by djsollen
Modified:
6 years, 3 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove legacy (and also broken) SkPicture constructor. Committed: https://skia.googlesource.com/skia/+/5ee785d9c7a39b9b8d3ae48b5da170dcef848e11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
djsollen
6 years, 3 months ago (2014-09-02 18:09:02 UTC) #2
robertphillips
lgtm but is Android weaned off of this?
6 years, 3 months ago (2014-09-02 18:17:34 UTC) #3
djsollen
On 2014/09/02 18:17:34, robertphillips wrote: > lgtm but is Android weaned off of this? Yes, ...
6 years, 3 months ago (2014-09-02 20:20:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/532703004/1
6 years, 3 months ago (2014-09-02 20:21:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5ee785d9c7a39b9b8d3ae48b5da170dcef848e11
6 years, 3 months ago (2014-09-02 20:34:54 UTC) #7
reed1
6 years, 3 months ago (2014-09-02 20:35:22 UTC) #8
Message was sent while issue was closed. 
api lgtm

Powered by Google App Engine
This is Rietveld 408576698