Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 532643002: Move pending async script to the correct resolved document. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
Reviewers:
haraken, tkent, Nate Chapin
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move pending async script to the correct resolved document. Follow up r181081 and move the pending script load to the document we're executing in the context of. R=haraken BUG=409618 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181374

Patch Set 1 #

Patch Set 2 : Extend to SVG script elements #

Patch Set 3 : Reduce flakiness potential #

Patch Set 4 : Update expected outputs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-crash-expected.txt View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-error-crash.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/append-child-adopt-node-error-crash-expected.txt View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-error-frame.html View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-error-frame.svg View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.html View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/resources/append-child-adopt-node-frame.svg View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/resources/should-load.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
sof
Please take a look. Handling a corner case missed by the initial fix.
6 years, 3 months ago (2014-09-02 07:21:54 UTC) #2
sof
The r181081-added test for the error case is proving a bit flaky wrt output order. ...
6 years, 3 months ago (2014-09-02 14:23:26 UTC) #3
haraken
LGTM, but Nate wants to confirm.
6 years, 3 months ago (2014-09-02 14:38:06 UTC) #4
sof
On 2014/09/02 14:38:06, haraken wrote: > LGTM, but Nate wants to confirm. Thanks, definitely :)
6 years, 3 months ago (2014-09-02 18:21:02 UTC) #5
sof
japhet: got time to look this one over? tia.
6 years, 3 months ago (2014-09-03 18:21:15 UTC) #6
sof
I don't want this bug to hang around. tkent@: does the context document lookup added ...
6 years, 3 months ago (2014-09-04 05:41:08 UTC) #8
haraken
On 2014/09/04 05:41:08, sof wrote: > I don't want this bug to hang around. > ...
6 years, 3 months ago (2014-09-04 05:45:10 UTC) #9
sof
On 2014/09/04 05:45:10, haraken wrote: > On 2014/09/04 05:41:08, sof wrote: > > I don't ...
6 years, 3 months ago (2014-09-04 06:02:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/532643002/60001
6 years, 3 months ago (2014-09-04 06:02:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/532643002/60001
6 years, 3 months ago (2014-09-04 14:34:38 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 16:01:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181374

Powered by Google App Engine
This is Rietveld 408576698