chrome/browser/metrics/network_metrics_provider.h - Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/network_metrics_provider.h

Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/metrics_service_accessor.cc ('k') | chrome/browser/metrics/network_metrics_provider.cc » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/network_metrics_provider.h

diff --git a/chrome/browser/metrics/network_metrics_provider.h b/chrome/browser/metrics/network_metrics_provider.h

index bfcdda0e173c45f2c46df1318c67866f3b479910..f6b4104f5a172f8e81ccbc19b5168bdf54754b86 100644

--- a/chrome/browser/metrics/network_metrics_provider.h

+++ b/chrome/browser/metrics/network_metrics_provider.h

@@ -23,7 +23,9 @@ class NetworkMetricsProvider

NetworkMetricsProvider();

virtual ~NetworkMetricsProvider();

+ private:

// metrics::MetricsProvider:

+ virtual void OnDidCreateMetricsLog() OVERRIDE;

virtual void ProvideSystemProfileMetrics(

metrics::SystemProfileProto* system_profile) OVERRIDE;

@@ -31,7 +33,6 @@ class NetworkMetricsProvider

virtual void OnConnectionTypeChanged(

net::NetworkChangeNotifier::ConnectionType type) OVERRIDE;

- private:

metrics::SystemProfileProto::Network::ConnectionType

GetConnectionType() const;

metrics::SystemProfileProto::Network::WifiPHYLayerProtocol