Revert of Fix crash when accessing Event::path().

Revert of Fix crash when accessing Event::path(). (patchset #4 id:60001 of https://codereview.chromium.org/516843004/)

Reason for revert:
The test crash-on-querying-event-path.html is unacceptably flaky.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=http%2Ftests%2Fdom%2Fcrash-on-querying-event-path.html&testType=layout-tests


Original issue's description:
> Fix crash when accessing Event::path().
> 
> (A more elaborate account of the details is found in the bug report.)
> 
> BUG=400476
> R=haraken@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181200

TBR=haraken@chromium.org,vogelheim@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400476
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181205

[tkent, 2014-09-02 01:53:46]

Created Revert of Fix crash when accessing Event::path().

[haraken, 2014-09-02 01:54:20]

LGTM, thanks for the revert.

[commit-bot: I haz the power, 2014-09-02 01:54:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/532593002/1

[commit-bot: I haz the power, 2014-09-02 01:55:06]

Committed patchset #1 (id:1) as 181205

[blink-reviews, 2014-09-02 08:23:45]

Ah, sorry for the troubles.

When I examine the test results, it seems the test runs multiple times.
That is, I get the set of expected 'PASS' and 'TEST COMPLETED' messages,
twice. I haven't observed that during development. It does look like
something that should be possible to de-flake. I'll have another look.


On Tue, Sep 2, 2014 at 3:54 AM, <haraken@chromium.org> wrote:

> LGTM, thanks for the revert.
>
>
> https://codereview.chromium.org/532593002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[blink-reviews, 2014-09-02 09:37:49]

So...

- I can reproduce the flakiness locally if I run the test in a loop.
- As said before, flakiness is due to the test messages being called
multiple times.
- This is due to the iframe's onload handler being called multiple times.
- I have no idea why this happens, but it's easy check for this condition.
I'll send a new CL soon-ish.



On Tue, Sep 2, 2014 at 10:23 AM, Daniel Vogelheim <vogelheim@google.com>
wrote:

> Ah, sorry for the troubles.
>
> When I examine the test results, it seems the test runs multiple times.
> That is, I get the set of expected 'PASS' and 'TEST COMPLETED' messages,
> twice. I haven't observed that during development. It does look like
> something that should be possible to de-flake. I'll have another look.
>
>
> On Tue, Sep 2, 2014 at 3:54 AM, <haraken@chromium.org> wrote:
>
>> LGTM, thanks for the revert.
>>
>>
>> https://codereview.chromium.org/532593002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.