Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 532583002: Revert of Revert of Add gamma/sRGB tag to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed2
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/525113005/) Reason for revert: Experiment to see resulting failures Original issue's description: > Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/) > > Reason for revert: > seems to be breaking layout tests in roll > > Original issue's description: > > Add gamma/sRGB tag to SkImageInfo > > > > This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb > > TBR=reed@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4581828014eb3d015e6ed55c9a5b6932b8751818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -46 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +64 lines, -25 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +111 lines, -21 lines 0 comments Download
A tests/ImageInfoTest.cpp View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Revert of Add gamma/sRGB tag to SkImageInfo
6 years, 3 months ago (2014-09-02 01:35:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/532583002/1
6 years, 3 months ago (2014-09-02 01:36:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4581828014eb3d015e6ed55c9a5b6932b8751818
6 years, 3 months ago (2014-09-02 01:36:28 UTC) #3
reed2
6 years, 3 months ago (2014-09-02 11:13:57 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/524593005/ by reed@chromium.org.

The reason for reverting is: linux_blink_rel

[ RUN      ] DeferredImageDecoderTest.drawIntoSkPicture
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:172:
Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) |
(static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) |
(static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[1457/1458] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[ RUN      ] DeferredImageDecoderTest.decodeOnOtherThread
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:233:
Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) |
(static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) |
(static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
[1458/1458] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
Retrying 2 tests (retry #2)
.

Powered by Google App Engine
This is Rietveld 408576698